Promoting new bundle directory structure as best practice #14993
Conversation
yceruto
force-pushed
the
bundles_structure
branch
2 times, most recently
from
a446761 to
7ae696f
Compare
|
What's our official recommendation for existing third-party bundles that no longer support 3.4. Do we encourage them to upgrade their structure or it's better to use this only in brand-new bundles? Related to the previous question, even if we don't recommend to change the structure for existing bundles, can you think of any problem if they do? Thanks! |
yceruto
force-pushed
the
bundles_structure
branch
from
7ae696f to
0b6e53c
Compare
There was a problem hiding this comment.
Thank you.
Do we encourage them to upgrade their structure or it's better to use this only in brand-new bundles?
They can do whatever they want. Im not sure we should give an opinon. Both work and we find the new structure to be better. Where "better" means, more "PHP" and less "symfony specific"
|
|
||
| class AcmeBlogBundle extends Bundle | ||
| { | ||
| public function getPath(): string |
There was a problem hiding this comment.
BTW, should we deprecate not overriding this method, so that we can make this the default in sf 6.0?
There was a problem hiding this comment.
I was wondering the same thing, I think we can do that when we decide to start depreciating the old structure.
As long as the old structure is kept alive, I don't think we should encourage upgrading, at least not now. Maybe when we start deprecating the old structure.
As long as the bundle is strictly compatible with Sf >= 4.4 shouldn't be a problem 🤞 |
|
maybe the doc should have a note saying that this structure can be used only when requiring |
yceruto
force-pushed
the
bundles_structure
branch
from
0b6e53c to
e1c0e65
Compare
yceruto
force-pushed
the
bundles_structure
branch
from
e1c0e65 to
8099f56
Compare
|
Updated:
|
javiereguiluz
force-pushed
the
bundles_structure
branch
from
39f09cc to
d44bfa8
Compare
|
Fantastic changes! Thanks Yonel. Merged! |
As Symfony 3.4 is not currently supported (security fixes only) I would like to propose to start promoting the new bundle directory structure (compatible since 4.4) consistent with the project one.
What do you think?
Fix: #12156
PR: symfony/symfony#32845